[ 
https://issues.apache.org/jira/browse/MAPREDUCE-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13036373#comment-13036373
 ] 

Hadoop QA commented on MAPREDUCE-2495:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12479790/MAPREDUCE-2495-v3.patch
  against trunk revision 1124553.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: 
https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/274//testReport/
Findbugs warnings: 
https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/274//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/274//console

This message is automatically generated.

> The distributed cache cleanup thread has no monitoring to check to see if it 
> has died for some reason
> -----------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2495
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2495
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: distributed-cache
>    Affects Versions: 0.21.0
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>            Priority: Minor
>         Attachments: MAPREDUCE-2495-20.20X-V1.patch, 
> MAPREDUCE-2495-20.20X-V2.patch, MAPREDUCE-2495-20.20X-V3.patch, 
> MAPREDUCE-2495-v1.patch, MAPREDUCE-2495-v2.patch, MAPREDUCE-2495-v3.patch
>
>
> The cleanup thread in the distributed cache handles IOExceptions and the like 
> correctly, but just to be a bit more defensive it would be good to monitor 
> the thread, and check that it is still alive regularly, so that the 
> distributed cache does not fill up the entire disk on the node. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to