[
https://issues.apache.org/jira/browse/MAPREDUCE-2384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13037456#comment-13037456
]
Hadoop QA commented on MAPREDUCE-2384:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12480002/MAPREDUCE-2384.r1.diff
against trunk revision 1125599.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results:
https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/289//testReport/
Findbugs warnings:
https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/289//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/289//console
This message is automatically generated.
> Can MR make error response Immediately?
> ---------------------------------------
>
> Key: MAPREDUCE-2384
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2384
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: job submission
> Affects Versions: 0.21.0
> Reporter: Denny Ye
> Assignee: Harsh J Chouraria
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2384.r1.diff
>
>
> When I read the source code of MapReduce in Hadoop 0.21.0, sometimes it made
> me confused about error response. For example:
> 1. JobSubmitter checking output for each job. MapReduce makes rule to
> limit that each job output must be not exist to avoid fault overwrite. In my
> opinion, MR should verify output at the point of client submitting. Actually,
> it copies related files to specified target and then, doing the verifying.
> 2. JobTracker. Job has been submitted to JobTracker. In first step,
> JT create JIT object that is very "huge" . Next step, JT start to verify job
> queue authority and memory requirements.
>
> In normal case, verifying client input then response immediately if
> any cases in fault. Regular logic can be performed if all the inputs have
> passed.
> It seems like that those code does not make sense for understanding.
> Is only my personal opinion? Wish someone help me to explain the details.
> Thanks!
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
