[
https://issues.apache.org/jira/browse/MAPREDUCE-2557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045269#comment-13045269
]
Hadoop QA commented on MAPREDUCE-2557:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12481646/MAPREDUCE-2557-style.patch
against trunk revision 1132807.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these core unit tests:
org.apache.hadoop.cli.TestMRCLI
org.apache.hadoop.fs.TestFileSystem
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/354//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/354//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/354//console
This message is automatically generated.
> Counters don't reset state when readFields() called
> ---------------------------------------------------
>
> Key: MAPREDUCE-2557
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2557
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: William Slacum
> Priority: Trivial
> Attachments: MAPREDUCE-2557-style.patch, MAPREDUCE-2557.patch
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> When calling readFields() on a Counters object, the internal state is not
> completely reset. The IdentityHashMap<Enum<?>, Counter> cache retains all
> previous mappings, even after the actual CounterGroups are changed. Using the
> same Counters pointer over and over again results in the cache always keeping
> the mapping for the first call to getCounter(Enum<?>). I've add a clear()
> call to the cache when readFields() is called and added a unit test to verify
> that it works.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
