[
https://issues.apache.org/jira/browse/MAPREDUCE-2660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061822#comment-13061822
]
Hadoop QA commented on MAPREDUCE-2660:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12485703/MAPREDUCE-2660-MR-279.patch
against trunk revision 1144097.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 patch. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/444//console
This message is automatically generated.
> MR-279: org.apache.hadoop.mapred.CombineFileInputFormat.getSplits() throws
> ArrayStoreException
> ----------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2660
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2660
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Attachments: MAPREDUCE-2660-MR-279.patch
>
>
> In branch MR-279, org.apache.hadoop.mapred.getSplits() throws
> RuntimeException:ArrayStoreException
> The following code in trunk:
> {noformat}
> public InputSplit[] getSplits(JobConf job, int numSplits)
> throws IOException {
> List<org.apache.hadoop.mapreduce.InputSplit> newStyleSplits =
> super.getSplits(new Job(job));
> InputSplit[] ret = new InputSplit[newStyleSplits.size()];
> for(int pos = 0; pos < newStyleSplits.size(); ++pos) {
> org.apache.hadoop.mapreduce.lib.input.CombineFileSplit newStyleSplit =
> (org.apache.hadoop.mapreduce.lib.input.CombineFileSplit)
> newStyleSplits.get(pos);
> ret[pos] = new CombineFileSplit(job, newStyleSplit.getPaths(),
> newStyleSplit.getStartOffsets(), newStyleSplit.getLengths(),
> newStyleSplit.getLocations());
> }
> return ret;
> }
> {noformat}
> got changed to
> {noformat}
> public InputSplit[] getSplits(JobConf job, int numSplits)
> throws IOException {
> return super.getSplits(new Job(job)).toArray(new InputSplit[0]);
> }
> {noformat}
> Code in trunk works fine. We should change the code in MR-279 to the same in
> trunk.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
