[
https://issues.apache.org/jira/browse/MAPREDUCE-2669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13066546#comment-13066546
]
Devaraj K commented on MAPREDUCE-2669:
--------------------------------------
It is good to see these examples.
There are few comments with this patch.
1. Use indentation two spaces per level, not four.
2. Before submitting the patch you can test the patch using the test-patch
target to avoid these -1's from the Hadoop QA like find bug issues.
You can refer here for more details:
http://wiki.apache.org/hadoop/HowToContribute
3. Streams can be closed properly by considering the exceptional cases also.
Refer discussion in the defect MAPREDUCE-2243.
4. Use some meaningful name for the test names instead of test.
5. Move these test classes from source code to the src/test/mapred.
You can file this in the review board because it is having good number of
changes and also can be reviewed thoroughly by reviewers.
> Some new examples and test cases for them.
> ------------------------------------------
>
> Key: MAPREDUCE-2669
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2669
> Project: Hadoop Map/Reduce
> Issue Type: Test
> Components: examples
> Affects Versions: 0.22.0
> Reporter: Plamen Jeliazkov
> Priority: Minor
> Attachments: MAPREDUCE-2669.patch, MAPREDUCE-2669.patch,
> MAPREDUCE-2669.patch, MAPREDUCE-2669.patch, mapreduce-new-examples-0.22.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Looking to add some more examples such as Mean, Median, and Standard
> Deviation to the examples.
> I have some generic JUnit testcases as well.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
