[ 
https://issues.apache.org/jira/browse/MAPREDUCE-2623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13066726#comment-13066726
 ] 

Hadoop QA commented on MAPREDUCE-2623:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12483950/MAPREDUCE-2623.r2.diff
  against trunk revision 1146517.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    -1 findbugs.  The patch appears to introduce 1 new Findbugs (version 1.3.9) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    -1 core tests.  The patch failed these core unit tests:
                  org.apache.hadoop.cli.TestMRCLI
                  org.apache.hadoop.fs.TestFileSystem
                  org.apache.hadoop.mapred.TestRecoveryManager

    -1 contrib tests.  The patch failed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/475//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/475//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/475//console

This message is automatically generated.

> Update ClusterMapReduceTestCase to use MiniDFSCluster.Builder
> -------------------------------------------------------------
>
>                 Key: MAPREDUCE-2623
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2623
>             Project: Hadoop Map/Reduce
>          Issue Type: Task
>          Components: test
>    Affects Versions: 0.23.0
>            Reporter: Jim Plush
>            Assignee: Harsh J
>            Priority: Minor
>             Fix For: 0.23.0
>
>         Attachments: MAPREDUCE-2623.r1.diff, MAPREDUCE-2623.r2.diff
>
>
> Looking at test class ClusterMapReduceTestCase it issues a warning that the 
> dfsCluster = new MiniDFSCluster(conf, 2, reformatDFS, null); line of code is 
> deprecated and MiniDFSCluster.Builder should be used instead. It notes that 
> the current API will be phased out in version 24. I propose to update the 
> test class to the most up to date code as it's referenced several places on 
> the internet as an example of how to write a Hadoop Unit Test.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to