[ 
https://issues.apache.org/jira/browse/MAPREDUCE-2643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13084557#comment-13084557
 ] 

Arun C Murthy commented on MAPREDUCE-2643:
------------------------------------------

Josh, thanks for updating the patch. Apologies for it going stale.

One nit: you've removed a bunch of exception handling in DefaultSpeculator, 
that will affect exceptions sent to the job-client?

> Fixing typos/formatting/null checking in v2.app.speculate package
> -----------------------------------------------------------------
>
>                 Key: MAPREDUCE-2643
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2643
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>          Components: mrv2
>            Reporter: Josh Wills
>            Assignee: Josh Wills
>            Priority: Minor
>             Fix For: 0.23.0
>
>         Attachments: MAPREDUCE-2643-1.patch, MAPREDUCE-2643.patch
>
>
> No functional changes in this patch: just fixing some typos in the comments, 
> fixing some formatting issues, renaming classes for consistency, and making 
> the null checking around Jobs/Tasks more consistent.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to