[ 
https://issues.apache.org/jira/browse/MAPREDUCE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13084569#comment-13084569
 ] 

Arun C Murthy commented on MAPREDUCE-2649:
------------------------------------------

Thomas, the patch looks good, thanks!

One thing that bothers me, nothing related to your patch of course, is that 
RMContextImpl.applications is manipulated in ClientRMService (submitApplication 
adds an RMApp to the list) and now, with your patch, RMAppExpirer removes it 
from the same list.

Should we consider renaming RMAppExpirer to something like RMAppManager which 
does both the add and delete? Thus ClientRMService should send an event to 
RMAppManager which then creates the RMApp, adds to list and sends other 
notifications. Similarly APP_COMPLETED comes over to RMAppManager which then 
deletes RMApps as in your patch. 
Thoughts? I'm fine doing this in another jira too... but it might improve the 
overall system rightaway. Thanks.

> MR279: Fate of finished Applications on RM
> ------------------------------------------
>
>                 Key: MAPREDUCE-2649
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2649
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>            Reporter: Thomas Graves
>            Assignee: Thomas Graves
>             Fix For: 0.23.0
>
>         Attachments: MAPREDUCE-2649-patch-mr279.txt, MAPREDUCE-2649-v2.patch, 
> MAPREDUCE-2649-v3.patch, MAPREDUCE-2649-v4.patch, MAPREDUCE-2649-v5.patch
>
>
> Today RM keeps the references of finished application for ever. Though this 
> is not sustainable long term, it keeps
> the user experience saner. Users can revisit RM UI and check the status of 
> their apps.
> We need to think of purging old references yet keeping the UX sane.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to