[
https://issues.apache.org/jira/browse/MAPREDUCE-2876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13091781#comment-13091781
]
Robert Joseph Evans commented on MAPREDUCE-2876:
------------------------------------------------
That is fine, and I am happy to change things however you want. But I don't
see AbstractLivenessMonitor deriving one value from another. Currently on
Trunk it has two methods.
{code}
protected void setExpireInterval(int expireInterval) {
this.expireInterval = expireInterval;
}
protected void setMonitorInterval(int monitorInterval) {
this.monitorInterval = monitorInterval;
}
{code}
I don't see anywhere that they are derived from one another.
AMLivelinessMonitor, ContainerAllocationExpirer, and NMLivelinessMonitor, all
of them extend AbstractLivnessMonitor. AM liveness has two configs
AM_EXPIRY_INTERVAL and AMLIVELINESS_MONITORING_INTERVAL. NM liveness does too
NM_EXPIRY_INTERVAL and NMLIVELINESS_MONITORING_INTERVAL. But container has
only one. CONTAINER_LIVELINESS_MONITORING_INTERVAL. Its value looks like a
copy and paste error and has the same value as
AMLIVELINESS_MONITORING_INTERVAL. It also uses
AMLIVELINESS_MONITORING_INTERVAL as the expiry interval.
If you want monitor interval derived from expiry that is fine. Should I set it
to something like 0.5 * expiry? If so I will then rename this issue.
> ContainerAllocationExpirer appears to use the incorrect configs
> ---------------------------------------------------------------
>
> Key: MAPREDUCE-2876
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2876
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 0.23.0
> Reporter: Robert Joseph Evans
> Assignee: Robert Joseph Evans
> Fix For: 0.23.0
>
>
> ContainerAllocationExpirer sets the expiration interval to be
> RMConfig.CONTAINER_LIVELINESS_MONITORING_INTERVAL but uses
> AMLIVELINESS_MONITORING_INTERVAL as the interval. This is very different
> from what AMLivelinessMonitor does.
> There should be two configs RMConfig.CONTAINER_LIVELINESS_MONITORING_INTERVAL
> for the monitoring interval and RMConfig.CONTAINER_EXPIRY_INTERVAL for the
> expiry.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
