[ 
https://issues.apache.org/jira/browse/MAPREDUCE-2745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098114#comment-13098114
 ] 

Anupam Seth commented on MAPREDUCE-2745:
----------------------------------------

Thanks Vinod for the help and the feedback! I have uploaded new patch - kindly 
review and let me know if it doesn't look good.

Test patch returns the following, but again all the findbugs warnings are in 
packages other than what I have touched and unrelated to any of my changes.

-1 overall.  

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    -1 findbugs.  The patch appears to introduce 26 new Findbugs (version 
1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.


> [MR-279] NM UI should get a read-only view instead of the actual NMContext 
> ---------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2745
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2745
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Vinod Kumar Vavilapalli
>            Assignee: Anupam Seth
>              Labels: newbie
>             Fix For: 0.23.0
>
>         Attachments: MAPREDUCE-2745-branch-0_23.patch, 
> MAPREDUCE-2745-branch-0_23_v2.patch
>
>
> NMContext is modifiable, the UI should only get read-only access. Just like 
> the AM web-ui.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to