[
https://issues.apache.org/jira/browse/MAPREDUCE-2690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Payne updated MAPREDUCE-2690:
----------------------------------
Attachment: MAPREDUCE-2690.2011-09-08.patch
Thanks for reviewing this, Arun.
Here are my responses to your review notes:
> 1.Heading should be 'FifoScheduler' rather than 'default queue'
The "Default Scheduler" heading came from the RmController class, which I did
not change.
However, I did change the QueuesBlock header to be 'FifoScheduler Queue'.
I also left "'default' Queue Status" because 'default' is coming from the
getQueueName() metohod.
Please take a look at the new screenshot to let me know what you think.
> 2.No need to show a bar for queue
Hmm... I think Ramya specifically wanted the queue bar. Can you please check
with her?
Ramya, what do you think about this one?
> 3.Alignment of text is broken (should be centre)
Done.
>4.Queue State is 'unknown' -> should be RUNNING/STOPPED
This value is coming from getQueueState() method. It was 'unknown' because the
FifoScheduler() constructor was not initializing the queue state. I added a fix
to this in FifoScheduler.java and it is working now.
> 5.Showing queue capacity is not useful with a single queue i.e drop
> max/total/current capacity
Done.
> Also, is there some unit tests we can add?
I updated the following test:
org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebApp.java
> Construct the web page for default scheduler
> --------------------------------------------
>
> Key: MAPREDUCE-2690
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2690
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 0.23.0
> Reporter: Ramya Sunil
> Assignee: Eric Payne
> Fix For: 0.23.0
>
> Attachments: DefSchedulerScreenshot.2011-09-08.png.jpg,
> DefaultSchedulerPage.jpg, MAPREDUCE-2690.2011-09-02.patch,
> MAPREDUCE-2690.2011-09-05.patch, MAPREDUCE-2690.2011-09-08.patch
>
>
> Currently, the web page for default scheduler reads as "Under construction".
> This is a long known issue, but could not find a tracking ticket. Hence
> opening one.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
