[ 
https://issues.apache.org/jira/browse/MAPREDUCE-2749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vinod Kumar Vavilapalli updated MAPREDUCE-2749:
-----------------------------------------------

    Attachment: MAPREDUCE-2749-20110912.txt

Alright, I took the liberty, went ahead and updated the tests. No changes other 
than the test code.

I still haven't figured out partial mocks/mockito-spies, so still using the 
age-old, extend-override-behaviour model for the test.

The new test is in {{TestNodeStatusUpdater}} and I removed the one you added in 
server-tests. Please look at it to see if it's okay.

(Your v4 patch and my patch differ in the file-order. If you want to see the 
diff of the patches, you can apply yours, generate a patch, then apply mine on 
a clean workspace, generate another patch and see the diff.)

> [MR-279] NM registers with RM even before it starts various servers
> -------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2749
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2749
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Vinod Kumar Vavilapalli
>            Assignee: Thomas Graves
>             Fix For: 0.23.0
>
>         Attachments: MAPREDUCE-2749-20110912.txt, MAPREDUCE-2749-v2.patch, 
> MAPREDUCE-2749-v3.patch, MAPREDUCE-2749-v4.patch, MAPREDUCE-2749.patch
>
>
> In case NM eventually fails to start the ContainerManager server because of 
> say a port clash, RM will have to wait for expiry to detect the NM crash.
> It is desirable to make NM register with RM only after it can start all of 
> its components successfully.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to