[ 
https://issues.apache.org/jira/browse/MAPREDUCE-2675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13102659#comment-13102659
 ] 

Robert Joseph Evans commented on MAPREDUCE-2675:
------------------------------------------------

I agree completely HsJobBlock will change quite a bit in MAPREDUCE-2676.  It 
probably would have been better to wait for that one to do the fork.

There are also some issues with the framework that make it difficult to not 
fork at least some of the code.  For example the Counters page is identical in 
both the application master and in the Job History Server, except in the Job 
History version it inherits from a different parent class to override the 
NavBlock and to remove the auto refresh that was initially there on several of 
the ApplicationMaster pages.   It also changes which section of the nav block 
that is expanded by default.  It would probably have been less code to sub 
class the original counters page and just override those parts that are 
different, but I thought being consistent on the pages in the History Server 
was better.

Ideally in the future we start creating some fairly standard widgets that can 
be reused in many different locations, then if there is a fork the amount of 
code being forked is much smaller.

> MR-279: JobHistory Server main page needs to be reformatted
> -----------------------------------------------------------
>
>                 Key: MAPREDUCE-2675
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2675
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>             Fix For: 0.23.0
>
>         Attachments: MR-2675-V1.patch, MR-2675-V2.patch, MR-2675-V3.patch, 
> MR-2675-V4.patch, MR-2675-V5.patch, MR-2675-preview.patch
>
>
> The main page of the Job History Server is based off of the Application 
> Master code.  It needs to be reformatted to be more useful and better match 
> what was there before.
> - The Active Jobs title needs to be replaced with something more appropriate 
> (i.e. Retired Jobs)
> - The table of jobs should have the following columns in it
>   - Submit time, Job Id, Job Name, User and just because I think it would be 
> useful state, maps completed, maps failed, reduces completed, reduces failed
> - The table needs more advanced filtering, something like 
> http://datatables.net/release-datatables/examples/api/multi_filter.html This 
> is to match the previous search functionality.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to