[
https://issues.apache.org/jira/browse/MAPREDUCE-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13102807#comment-13102807
]
jirapos...@reviews.apache.org commented on MAPREDUCE-2874:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1800/
-----------------------------------------------------------
Review request for Tom Graves.
Summary
-------
•I removed the Apps.toString(ApplicationId id) method from
o.a.h.yarn.util.Apps.java
•The Apps.toString(ApplicationId id) method was used by webapp APIs.
•Since this toString method has an ApplicationId as it's parameter, I replaced
every call to Apps.tostring(ApplicationId id) with a call to
ApplicationId.toString().
•The result is that in the yarn UI pages, job names now have the form
application_<epoch>_<job num> rather than app_<epoch>_<job num> (See Screenshot
AppStringNowApplicationString.2011-09-09.PNG)
This addresses bug MAPREDUCE-2874.
https://issues.apache.org/jira/browse/MAPREDUCE-2874
Diffs
-----
branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/webapp/AppController.java
1167373
branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/webapp/TestAMWebApp.java
1167373
branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/webapp/TestHSWebApp.java
1167373
branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/Apps.java
1167373
branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppsBlock.java
1167373
branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppsList.java
1167373
Diff: https://reviews.apache.org/r/1800/diff
Testing
-------
Thanks,
Eric
> ApplicationId printed in 2 different formats and has 2 different toString
> routines that are used
> ------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2874
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2874
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 0.23.0
> Reporter: Thomas Graves
> Assignee: Eric Payne
> Fix For: 0.23.0
>
> Attachments: AppStringNowApplicationString.2011-09-09.PNG.jpg,
> MAPREDUCE-2874.2011-09-09.patch
>
>
> Looks like the ApplicationId is now printed in 2 different formats.
> ApplicationIdPBImpl.java has a toString routine that prints it in the format:
> return "application_" + this.getClusterTimestamp() + "_" + this.getId();
> While the webapps use
> ./hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/Apps.java
> toString that prints it like:
> return _join("app", id.getClusterTimestamp(), id.getId());
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
