[
https://issues.apache.org/jira/browse/MAPREDUCE-2899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104203#comment-13104203
]
Siddharth Seth commented on MAPREDUCE-2899:
-------------------------------------------
Mostly looks good. 1 issue needs to be fixed
- ApplicationSubmissionContextPBImpl.setContainerLaunchContext should not
return after builder.clearAmContainer
Other minor stuff
- YARNRunner.createApplicationSubmissionContext.fsTokens is no longer required.
- AppsBlock -> does the anchor text ApplicationMaster, JobHistory need to have
URL appended ?
- ClientRMService -> the user safety check could be a comparison of
submissionContext.getUser and ugi.getUser
- Can the proto fields be renamed to be close to the actual interface. Will
make things easier for a PBImpl code generator if we ever get to one.
ContainerLaunchContextProto.env to ContainerLuanchContextProto.environment and
ApplicationSubmissionContextProto.am_container to containerLaunchContext (or
change the ASC api to getAmContainer)
> Replace major parts of ApplicationSubmissionContext with a
> ContainerLaunchContext
> ---------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2899
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2899
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: mrv2, resourcemanager
> Reporter: Arun C Murthy
> Assignee: Arun C Murthy
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2899.patch, MAPREDUCE-2899.patch,
> MAPREDUCE-2899.patch
>
>
> We can replace major parts of ApplicationSubmissionContext with a
> ContainerLaunchContext.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
