[ 
https://issues.apache.org/jira/browse/MAPREDUCE-3011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13105215#comment-13105215
 ] 

Ravi Gummadi commented on MAPREDUCE-3011:
-----------------------------------------

I too have that concern of "TT not handling the case of 'bad disks becoming 
good'".

BTW, How expensive is this check in DiskChecker.checkDirs() ? This is not being 
called for bad local dirs in the current code of TT.offerService(). 
LocalDirAllocator object being held by TaskController is also updated by 
TT.initialize(). We need to see if we can update all LocalDirAllocator objects 
with good local dirs list, if we are not doing that already. Will it be good 
enough here and for HADOOP-7551 ? 

> TT should remove bad local dirs from conf to prevent constant disk checking
> ---------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3011
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3011
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>          Components: tasktracker
>    Affects Versions: 0.20.204.0
>            Reporter: Eli Collins
>             Fix For: 0.20.205.0
>
>
> Per HADOOP-7551 the TT does not remove bad mapred.local.dirs from the conf so 
> after a single disk failure *every* call to get a local path for reading or 
> writing results in a disk check of *all* configured local dirs. After 
> detecting that a local dir is bad we should remove it from the conf so that 
> we don't repeatedly perform this expensive operation.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to