[ 
https://issues.apache.org/jira/browse/MAPREDUCE-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13105531#comment-13105531
 ] 

Hadoop QA commented on MAPREDUCE-2785:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12494654/MAPREDUCE-2785.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/752//console

This message is automatically generated.

> MiniMR cluster thread crashes if no hadoop log dir set
> ------------------------------------------------------
>
>                 Key: MAPREDUCE-2785
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2785
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: jobtracker
>    Affects Versions: 0.20.203.0
>            Reporter: Steve Loughran
>            Priority: Minor
>             Fix For: 0.20.206.0
>
>         Attachments: MAPREDUCE-2785.patch
>
>
> I'm marking this as minor as it is most obvious in the MiniMRCluster, but the 
> root cause is in the JT. 
> If you instantiate an MiniMR Cluster without setting 
> {{hadoop.job.history.location}} in the configuration and the system property 
> {{hadoop.log.dir}} unset, then the JobHistory throws an NPE. In production, 
> that would be picked up as a failure to start the JT. In the MiniMRCluster, 
> all it does is crash the JT thread -which isn't noticed by the MiniMR 
> cluster. You see the logged error, but the tests will just timeout waiting 
> for things to come up
> 2011/08/08 17:46:26:427 CEST [ERROR][Thread-44] 
> org.apache.hadoop.mapred.MiniMRCluster - Job tracker crashed 
> <java.lang.NullPointerException>         java.lang.NullPointerException
>       at java.io.File.<init>(File.java:222)
>       at org.apache.hadoop.mapred.JobHistory.initLogDir(JobHistory.java:531)
>       at org.apache.hadoop.mapred.JobHistory.init(JobHistory.java:499)
>       at org.apache.hadoop.mapred.JobTracker$2.run(JobTracker.java:2316)
>       at org.apache.hadoop.mapred.JobTracker$2.run(JobTracker.java:2313)
>       at java.security.AccessController.doPrivileged(Native Method)
>       at javax.security.auth.Subject.doAs(Subject.java:396)
>       at 
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1059)
>       at org.apache.hadoop.mapred.JobTracker.<init>(JobTracker.java:2313)
>       at org.apache.hadoop.mapred.JobTracker.<init>(JobTracker.java:2171)
>       at org.apache.hadoop.mapred.JobTracker.startTracker(JobTracker.java:300)
>       at 
> org.apache.hadoop.mapred.MiniMRCluster$JobTrackerRunner$1.run(MiniMRCluster.java:114)
>       at 
> org.apache.hadoop.mapred.MiniMRCluster$JobTrackerRunner$1.run(MiniMRCluster.java:112)
>       at java.security.AccessController.doPrivileged(Native Method)
>       at javax.security.auth.Subject.doAs(Subject.java:396)
>       at 
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1059)
>       at 
> org.apache.hadoop.mapred.MiniMRCluster$JobTrackerRunner.run(MiniMRCluster.java:112)
>       at java.lang.Thread.run(Thread.java:662)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to