[
https://issues.apache.org/jira/browse/MAPREDUCE-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13106646#comment-13106646
]
Luke Lu commented on MAPREDUCE-3003:
------------------------------------
bq. mvn versions:set -DnewVersion=0.24.1-SNAPSHOT -f hadoop-project/pom.xml,
You'll get all common/hdfs modules updated correctly to the new version in one
shot.
Compare that to the approach #1, where you don't need to set any version and
can just activate a profile implicitly in settings.xml or just use -Pmyprofile.
You keep talking about the "vanilla maven" way without any references,
especially in light of the history maven that they did attempt interpolation in
2.0.9 then backed out in 2.0.10 because it was half baked. I'd appreciate that
you have references (like I did) to back your assertions up. The pom version
resolution is mess in the current maven, and the approach #1 is the most
convenient to developers for large scale projects. BTW, you forgot the
top-level pom, which needs another command. The top-level aggregation pom also
needs to inherit from the hadoop-project/pom.xml, in order to have a single
command to switch project versions.
bq. When we normalize all the MR modules, the 'versions:set' would work for all.
That was my point, it's more complicated than you think and your latest patch
doesn't work that way. I'm fine with approach #2, as long as it's made to work
reasonably well, the current patch doesn't.
bq. A comment on the latest patch, it is a Maven good practice (also an issue
of eternal discussions in Mavenland) that children have their version
explictly, not only getting them from the parent.
Again, citation needed. You can't just make up a "maven good practice" on the
spot, given MNG-624 is still an open issue. Aesthetically speaking, the
duplicated version clauses are redundant and pollute the diff views even more,
which is already the biggest downside of versions:set.
The bottom line is that the current patch does *not* work, you need more
changes (fix the properties references as well as the inheritance change) to
make the version switch tolerable.
> Publish Yarn and MapReduce artifacts to Maven snapshot repository
> -----------------------------------------------------------------
>
> Key: MAPREDUCE-3003
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3003
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: build
> Reporter: Tom White
> Assignee: Tom White
> Attachments: MAPREDUCE-3003-0.23.patch, MAPREDUCE-3003.patch,
> MAPREDUCE-3003.patch, MAPREDUCE-3003.patch
>
>
> Currently this is failing since no distribution management section is defined
> in the POM.
> https://builds.apache.org/view/G-L/view/Hadoop/job/Hadoop-Common-trunk-Commit/883/consoleFull
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
