[
https://issues.apache.org/jira/browse/MAPREDUCE-2790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13106765#comment-13106765
]
[email protected] commented on MAPREDUCE-2790:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1791/#review1941
-----------------------------------------------------------
Ship it!
+1 (non-binding)
trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/RMAppImpl.java
<https://reviews.apache.org/r/1791/#comment4425>
Lin3 304 of RMAppImpl.java:
Calling getJustFinishedContainers().size() may not be the best way to
handle this since this list gets cleared when AllocateResponse.allocate(...)
calls appAttempt.pullJustFinishedContainers(). AllocateResponse.allocate(...)
is calling this as part of the allocateResponse.
I think we want to keep track of the total number of containers that the
app attempt used, which info is not currently in the RMAppAttemptImpl class. I
tried adding a private variable that is incremented whenever the
justFinishedContainers list is cleared, and this seems to get what we want.
- Eric
On 2011-09-13 16:52:50, Ravi Prakash wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1791/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-13 16:52:50)
bq.
bq.
bq. Review request for Tom Graves, Jeffrey Naisbitt, Robert Evans, and
Jonathan Eagles.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Add additional field for storing the AM/job history info on CLI (
https://issues.apache.org/jira/browse/MAPREDUCE-2790 )
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/TypeConverter.java
1170200
bq.
trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobStatus.java
1170200
bq.
trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/JobStatus.java
1170200
bq.
trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/tools/CLI.java
1170200
bq.
trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/ClientServiceDelegate.java
1170200
bq.
trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ApplicationReport.java
1170200
bq.
trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ApplicationReportPBImpl.java
1170200
bq.
trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_protos.proto
1170200
bq.
trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/BuilderUtils.java
1170200
bq.
trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/MockApps.java
1170200
bq.
trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/RMAppImpl.java
1170200
bq.
bq. Diff: https://reviews.apache.org/r/1791/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Ravi
bq.
bq.
> [MR-279] Add additional field for storing the AM/job history info on CLI
> ------------------------------------------------------------------------
>
> Key: MAPREDUCE-2790
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2790
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 0.23.0
> Reporter: Ramya Sunil
> Assignee: Ravi Prakash
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2790.v1.txt, MAPREDUCE-2790.v2.txt,
> MAPREDUCE-2790.v3.txt, MAPREDUCE-2790.v4.txt
>
>
> bin/mapred job [-list [all]] displays the AM or job history location in the
> "SchedulingInfo" field. An additional column has to be added to display the
> AM/job history information. Currently, the output reads:
> {noformat}
> JobId State StartTime UserName Queue Priority
> SchedulingInfo
> jobID FAILED 0 ramya default NORMAL AM
> information/job history location
> {noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
