[
https://issues.apache.org/jira/browse/MAPREDUCE-2925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13107052#comment-13107052
]
Vinod Kumar Vavilapalli commented on MAPREDUCE-2925:
----------------------------------------------------
Few more comments:
ClientServiceDelegate
- Please move the application null check into the while loop, it can happen
any time. (1)
- I think it is a bit harsh to throw an exception when HS isn't configured.
May be just log the warn the message and return a {{NotRunningJob}}. What do
you think?
- We don't use {{YarnRemoteExceptionPBImpl}} directly, instead we use
{{RPCUtil.getRemoteException()}} (Hiding the underlying impl and all). Once you
do (1) above, your patch actually won't need this change in the main code, but
you will need it in the test. Also there are other similar usages in
_ClientServiceDelegate_ though unrelated to your patch. Mind changing them as
well?
TestClientServiceDelegate: Overall looks good, appreciate the meaningfulness of
the tests, good job!
- Again, replace the PB Impl objects creation using {{BuilderUtils}} methods
or {{Records.newRecord()}}
- I suggest the test names to be _testUnknownAppInRM_,
_testHistoryServerNotConfigured_ (with the two tests related to non-configured
JHS combined into one), _testRemoteExceptionFromHistoryServer_,
_testRetriesOnConnectionFailure_ respectively.
> job -status <JOB_ID> is giving continuously info message for completed jobs
> on the console
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2925
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2925
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 0.23.0
> Reporter: Devaraj K
> Assignee: Devaraj K
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2925-1.patch, MAPREDUCE-2925-2.patch,
> MAPREDUCE-2925.patch
>
>
> This below message is coming continuously on the console.
> {code:xml}
> 11/09/02 16:00:00 INFO mapred.ClientServiceDelegate: Failed to contact AM for
> job job_1314955256658_0009 Will retry..
> 11/09/02 16:00:00 INFO mapred.ClientServiceDelegate: Application state is
> completed. Redirecting to job history server null
> 11/09/02 16:00:00 INFO mapred.ClientServiceDelegate: Failed to contact AM for
> job job_1314955256658_0009 Will retry..
> 11/09/02 16:00:00 INFO mapred.ClientServiceDelegate: Application state is
> completed. Redirecting to job history server null
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
