[
https://issues.apache.org/jira/browse/MAPREDUCE-2965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13107359#comment-13107359
]
Hadoop QA commented on MAPREDUCE-2965:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12494960/MR2965_v5.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 11 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/776//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/776//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-yarn-api.html
Console output:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/776//console
This message is automatically generated.
> Streamline hashCode(), equals(), compareTo() and toString() for all IDs
> -----------------------------------------------------------------------
>
> Key: MAPREDUCE-2965
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2965
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Vinod Kumar Vavilapalli
> Assignee: Siddharth Seth
> Priority: Blocker
> Fix For: 0.23.0, 0.24.0
>
> Attachments: MR2965_v1.patch, MR2965_v2.patch, MR2965_v3.patch,
> MR2965_v4.patch, MR2965_v5.patch
>
>
> MAPREDUCE-2954 moved these methods to the record interfaces from the PB impls
> for ContainerId, ApplicationId and ApplicationAttemptId. This is good as they
> don't need to be tied to the implementation.
> We should do the same for all IDs. In fact some of these are missing for IDs
> like MR AM JobId, TaskId etc.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
