[
https://issues.apache.org/jira/browse/MAPREDUCE-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113186#comment-13113186
]
Matt Foley commented on MAPREDUCE-2928:
---------------------------------------
The patches mapreduce-2928-2.patch and mapreduce-2928-3.patch were generated
from different CMS and ended up with files in different order, which always
complicates comparison. However, analysis shows that the only substantive diffs
are:
{quote}
> Index: src/mapred/org/apache/hadoop/mapred/TaskTracker.java
> ===================================================================
@@ -856,13 +825,6 @@ public class TaskTracker implements MRConstants,
TaskUmbilicalProtocol,
[[ +12 lines ]]
< Class<? extends TaskTrackerInstrumentation> metricsInst =
< getInstrumentationClass(fConf);
---
> try {
> Class<? extends TaskTrackerInstrumentation> metricsInst =
@@ -1605,10 +1560,12 @@ public class TaskTracker implements MRConstants,
TaskUmbilicalProtocol,
[[ +4 lines ]]
< + int numFailures = lastNumFailures;
[[ +4 lines ]]
< + lastNumFailures = localStorage.numFailures();
---
> + int numFailures = localStorage.numFailures();
[[ +1 line ]]
< + if (numFailures < lastNumFailures) {
---
> + if (numFailures > lastNumFailures) {
> + lastNumFailures = numFailures;
{quote}
The first chunk is differences only in surrounding context, not in patched
lines. Thus, these changes are irrelevant to the code changed by this patch.
The second chunk is precisely the changes suggested by Ravi.
So, +1 on code review, per the previous reviewers' comments.
> MR-2413 improvements
> --------------------
>
> Key: MAPREDUCE-2928
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2928
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: tasktracker
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.20.205.0
>
> Attachments: mapreduce-2928-1.patch, mapreduce-2928-2.patch,
> mapreduce-2928-3.patch
>
>
> Tracks improvements to MR-2413. See [this
> comment|https://issues.apache.org/jira/browse/MAPREDUCE-2413?focusedCommentId=13095073&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13095073].
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
