[ 
https://issues.apache.org/jira/browse/MAPREDUCE-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113504#comment-13113504
 ] 

Vinod Kumar Vavilapalli commented on MAPREDUCE-2952:
----------------------------------------------------

Cancelled patch for fixing Jenkins warnings.

The patch mostly looks good, except I just cannot locate the source for 
RMAppFailedEvent.java. Late night work-jitters? Or is this missed in the patch?

Some other nits:
 - RMAppFailedEvent should actually be called RMAppAttemptFailedEvent.
 - RMAppEventType.ATTEMPT_KILLED is mostly a no-op, I can changes in 
RMAppAttemptImpl.BaseFinalTransition for this event can be undone.

> Application failure diagnostics are not consumed in a couple of cases
> ---------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2952
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2952
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, resourcemanager
>    Affects Versions: 0.23.0
>            Reporter: Vinod Kumar Vavilapalli
>            Assignee: Arun C Murthy
>            Priority: Blocker
>             Fix For: 0.23.0
>
>         Attachments: MAPREDUCE-2952.patch, MAPREDUCE-2952.patch
>
>
> When Container crashes, the reason for failures isn't propagated because of a 
> bug in _RMAppAttemptImpl.AMContainerCrashedTransition_ which simply discards 
> the diagnostics of the container. Also RMAppAttemptImpl.diagnostics is never 
> consumed.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to