[ 
https://issues.apache.org/jira/browse/MAPREDUCE-3008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117980#comment-13117980
 ] 

Ravi Gummadi commented on MAPREDUCE-3008:
-----------------------------------------

Some comments on the patch:

(1) Boosting is happening for map-only job's map task progress also. This can 
cause the progress value to become 1.0+0.33 ? Please check this case while 
boosting progress.

(2) The name of the variable "lastSeenCpuUsageCpuUsage" needs to be changed to 
"lastSeenCpuUsage".
                
> [Gridmix] Improve cumulative CPU usage emulation for short running tasks
> ------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3008
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3008
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>          Components: contrib/gridmix
>    Affects Versions: 0.24.0
>            Reporter: Amar Kamat
>              Labels: cpu-emulation, gridmix
>             Fix For: 0.24.0
>
>         Attachments: mapreduce-2591-v1.4.2.patch
>
>
> CPU emulation in Gridmix fails to meet the expected target if the map has no 
> data to sort/spill/merge. There are 2 major reasons for this:
> 1. The map task end immediately ends soon after the map task. The map 
> progress is 67% while the map phase ends. 
> 2. Currently, the sort (comparator) doesnt emulate CPU. If the map is short 
> lived, the CPU emulation thread (spawned from the map task in cleanup) 
> doesn't get a chance to emulate.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to