[
https://issues.apache.org/jira/browse/MAPREDUCE-3154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13123013#comment-13123013
]
Abhijit Suresh Shingate commented on MAPREDUCE-3154:
----------------------------------------------------
{quote}
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
{quote}
Only *_checkSpecs(job);_* call is moved to beginning of
JobSubmitter.submitJobInternal(Job, Cluster) method.
> Validate the Jobs Output Specification as the first statement in
> JobSubmitter.submitJobInternal(Job, Cluster) method
> --------------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-3154
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3154
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: client, mrv2
> Affects Versions: 0.23.0, 0.24.0
> Environment: mrv2
> Reporter: Abhijit Suresh Shingate
> Assignee: Abhijit Suresh Shingate
> Attachments: MAPREDUCE-3154.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Presently the output specification is validated after getting new JobId from
> ClientRMService, Copying the job jar, Configuration file, archives etc.
> Instead of that move following Job Output specification validation call to
> the begining of JobSubmitter.submitJobInternal(Job, Cluster) method.
> {code}
> checkSpecs(job);
> {code}
> This will avoid unnecessary work in case of invalid output specs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
