[
https://issues.apache.org/jira/browse/MAPREDUCE-3161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124680#comment-13124680
]
Vinod Kumar Vavilapalli commented on MAPREDUCE-3161:
----------------------------------------------------
Straightforward patch. Looks good. +1.
Thanks for resisting a developer's temptation of fixing code-bugs along with
typos ;)
Regarding the docs for the transitions (and also for events), I think
decorating them with annotations is really useful. For e.g, (start state, end
state) for transitions and (source, destination) pair for events. Will file a
separate ticket, I am fine passing that for this patch.
> Improve javadoc and fix some typos in MR2 code
> ----------------------------------------------
>
> Key: MAPREDUCE-3161
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3161
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: mrv2
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: mr-3161.txt
>
>
> Just some simple cleanup, documentation, typos in variable names, etc. The
> only code change is to refactor ResourceLocalizationService so each event
> type is handled in its own method instead of a giant switch statement (just
> using eclipse's Extract Method - no semantic change)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
