[ 
https://issues.apache.org/jira/browse/MAPREDUCE-3166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125654#comment-13125654
 ] 

Ravi Gummadi commented on MAPREDUCE-3166:
-----------------------------------------

Unit tests of Rumen and Gridmix passed on my local machine except 
TestCompressionEmulationUtils which is a known issue without this patch also.

test-patch along with MR-3157 gave the following:

-1 overall.  

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

    -1 release audit.  The applied patch generated 1 release audit warnings 
(more than the trunk's current 0 warnings).



I don't see any issues in patchReleaseAuditProblems.txt related to these 
patches.
                
> Make Rumen use job history api instead of relying on current history file 
> name format
> -------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3166
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3166
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: tools/rumen
>    Affects Versions: 0.23.0
>            Reporter: Ravi Gummadi
>            Assignee: Ravi Gummadi
>             Fix For: 0.23.0
>
>         Attachments: MR3166.patch
>
>
> Rumen should not depend on the regular expression of job history file name 
> format and should use the newly added api like isValidJobHistoryFileName(), 
> getJobIDFromHistoryFilePath().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to