[ 
https://issues.apache.org/jira/browse/MAPREDUCE-2788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127982#comment-13127982
 ] 

Ahmed Radwan commented on MAPREDUCE-2788:
-----------------------------------------

Yes CS.allocate() already calls normalizeRequests(..), no need to change 
anything there. But the call scenario described in my previous comment is the 
one causing the problem, not CS.allocate(..), it is the CS.addApplication(..). 

The latest patch fix to CS.addApplication(..) to also normalize requests is the 
one required. What do you think?
                
> LeafQueue.assignContainer() can cause a crash if 
> request.getCapability().getMemory() == 0
> -----------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2788
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2788
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>            Reporter: Ahmed Radwan
>            Assignee: Ahmed Radwan
>            Priority: Critical
>         Attachments: MAPREDUCE-2788.patch, MAPREDUCE-2788_rev2.patch, 
> MAPREDUCE-2788_rev3.patch
>
>
> The assignContainer() method in 
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue 
> can cause the scheduler to crash if the ResourseRequest capability memory == 
> 0 (divide by zero).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to