[
https://issues.apache.org/jira/browse/MAPREDUCE-3104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129455#comment-13129455
]
Siddharth Seth commented on MAPREDUCE-3104:
-------------------------------------------
Took a reasonably comprehensive look at the patch. Few minor issues.
- PBImpls.addApplicationACLs need to initialize the builder and clear the
existing entires (ref CLCPBImpl.addEnvToProto)
- Should ApplicationOperation be renamed to something like AppAccessOperation.
"ApplicationOperation" doesn't give a lot of context.
- MRJobConfig.JOB_ACL_* can have default values in MRJobConfig instead of
specifying " " in YARNRunner
- YarnConfiguration.RM_ADMIN_ACL - is really a Yarn ACL (including the NM).
Rename ?
- ResourceManager.init() -> has two configuration objects. Looks like either
can be used for AppAclsManager (one should ideally be removed)
- QueueACL needs a small javadoc update - 'jobs' to 'apps'
> Implement Application ACLs, Queue ACLs and their interaction
> ------------------------------------------------------------
>
> Key: MAPREDUCE-3104
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3104
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: mrv2, resourcemanager, security
> Affects Versions: 0.23.0
> Reporter: Vinod Kumar Vavilapalli
> Assignee: Vinod Kumar Vavilapalli
> Priority: Blocker
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-3104-20111017.3.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
