[
https://issues.apache.org/jira/browse/MAPREDUCE-3028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131717#comment-13131717
]
[email protected] commented on MAPREDUCE-3028:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2468/#review2701
-----------------------------------------------------------
Over all I would say the patch looks good. There are a few minor nits though.
branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/JobEndNotifier.java
<https://reviews.apache.org/r/2468/#comment6086>
Need to add in the Apache License.
branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/JobEndNotifier.java
<https://reviews.apache.org/r/2468/#comment6089>
Could you please put default values and documentation for the new configs
in mapred-default.xml. This is mostly for documentation of the new configs,
then it is for default values.
- Robert
On 2011-10-20 15:36:27, Ravi Prakash wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2468/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-20 15:36:27)
bq.
bq.
bq. Review request for Tom Graves, Robert Evans, Jonathan Eagles, and Mark
Holderbaugh.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Job end notification for 0.23 / next. I'm going to work on unit tests
while you folks review the code.
bq.
bq. The only new thing added to 0.20 is that multiple recipients can be
configured to receive the job-end notification by supplying multiple URLs (one
parameter separated by a regex)
bq.
bq.
bq. This addresses bug MAPREDUCE-3028.
bq. https://issues.apache.org/jira/browse/MAPREDUCE-3028
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/JobEndNotifier.java
PRE-CREATION
bq.
branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java
1186838
bq.
branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/MRJobConfig.java
1186838
bq.
bq. Diff: https://reviews.apache.org/r/2468/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Manually tested changes on a single node cluster. Going to add unit tests.
bq.
bq.
bq. Thanks,
bq.
bq. Ravi
bq.
bq.
> Support job end notification in .next /0.23
> -------------------------------------------
>
> Key: MAPREDUCE-3028
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3028
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Reporter: Mohammad Kamrul Islam
> Assignee: Ravi Prakash
> Priority: Blocker
> Fix For: 0.23.0
>
>
> Oozie primarily depends on the job end notification to determine when the
> job finishes. In the current version, job end notification is implemented in
> job tracker. Since job tracker will be removed in the upcoming hadoop release
> (.next), we wander where this support will move. I think this best effort
> notification could be implemented in the new Application Manager as one of
> the last step of job completion.
> Whatever implementation will it be, Oozie badly needs this feature to be
> continued in next releases as well.
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
