[ 
https://issues.apache.org/jira/browse/MAPREDUCE-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132324#comment-13132324
 ] 

Ravi Gummadi commented on MAPREDUCE-2957:
-----------------------------------------

Patch looks fine to me.
1 minor nit: If DEE is seen, then close() is called twice (once in finally 
block and 2nd time in shutDown()). If possible, we should avoid this (though 
calling close() twice may not be harmful except some more cpu-cycles-usage) ?
                
> The TT should not re-init if it has no good local dirs
> ------------------------------------------------------
>
>                 Key: MAPREDUCE-2957
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2957
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>          Components: tasktracker
>    Affects Versions: 0.20.204.0
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>         Attachments: mapreduce-2957-1.patch, mapreduce-2957.patch
>
>
> The TT will currently try to re-init itself on disk failure even if it has no 
> good local dirs. It should shutdown instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to