[
https://issues.apache.org/jira/browse/MAPREDUCE-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147214#comment-13147214
]
Matt Foley commented on MAPREDUCE-3374:
---------------------------------------
Here's the piece we needed:
-1 overall.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version )
warnings.
Since this patch is for build code, agree unit tests are inapplicable.
Therefore test-patch passes.
The unit tests are not run by normal developer invocation of test-patch, but
this patch is unlikely to affect the way task-controller runs, so we'll let
that pass too.
The patch makes sense to me.
+1 for code review. Please commit to branch-0.20-security and
branch-0.20-security-205.
Thanks!
> src/c++/task-controller/configure is not set executable in the tarball and
> that prevents task-controller from rebuilding
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-3374
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3374
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: task-controller
> Affects Versions: 0.20.205.0
> Reporter: Roman Shaposhnik
> Attachments: MAPREDUCE-3374.patch.txt, log.gz
>
>
> ant task-controller fails because src/c++/task-controller/configure is not
> set executable
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
