[ 
https://issues.apache.org/jira/browse/MAPREDUCE-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ahmed Radwan updated MAPREDUCE-3370:
------------------------------------

    Attachment: MAPREDUCE-3370_rev3.patch

Thanks!

Attaching an updated patch that also addresses the TestDistributedShell.

The JobConf.findContainingJar() doesn't work for the TestDistributedShell case 
because the test class is part of the app jar. Generally the ability to use 
JobConf.findContainigJar() will depend on how  maven works, when jars are 
created, and if tests are in separate modules. 

For this reason, I have updated the patch to first check for system properties, 
and if not set, find the containing jar. So no need to modify the test if we 
decided later to move tests into separate modules and not  using the system 
properties.
                
> MiniMRYarnCluster uses a hard coded path location for the MapReduce 
> application jar
> -----------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3370
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3370
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, test
>    Affects Versions: 0.23.0
>            Reporter: Ahmed Radwan
>            Assignee: Ahmed Radwan
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3370.patch, MAPREDUCE-3370_rev2.patch, 
> MAPREDUCE-3370_rev3.patch
>
>
> MiniMRYarnCluster uses a hard coded relative path location for the MapReduce 
> application jar. It is better to have this location as a system property so 
> tests can pick the application jar regardless of their working directory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to