[
https://issues.apache.org/jira/browse/MAPREDUCE-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ahmed Radwan updated MAPREDUCE-3169:
------------------------------------
Attachment: MAPREDUCE-3169-trunk_rev3.patch
Thanks Tom!
Please see updated patch incorporating your comments.
> Why do some operations in MiniMRCluster do nothing, while others throw a
> UnsupportedOperationException?
This was a subjective assessment, so methods that are tightly coupled with MR1
will throw an UnsupportedOperationException so they'll noisily fail. Other
methods are just unimplemented as the corresponding functionality is abscent in
MR2. I can change all of them to throw an UnsupportedOperationException but
wanted to be as flexible as possible with old code.
> Please add class-level javadoc.
Added to all new classes.
> MiniMRClientClusterFactory should use Class<?>, not a raw Class.
Change incorporated in the new patch.
> MiniMRYarnClusterAdapter might be better named MiniMRClientYarnCluster.
The name used is "MiniMRClientCluster". The MiniMRYarnClusterAdapter name is
used by the adapter for MiniMRYarnCluster providing the MiniMRClientCluster
interface.
> Create a new MiniMRCluster equivalent which only provides client APIs cross
> MR1 and MR2
> ---------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-3169
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3169
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: mrv1, mrv2, test
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Ahmed Radwan
> Attachments: MAPREDUCE-3169-0.20-security.patch,
> MAPREDUCE-3169-truck.patch, MAPREDUCE-3169-trunk_rev2.patch,
> MAPREDUCE-3169-trunk_rev3.patch
>
>
> Many dependent projects like HBase, Hive, Pig, etc, depend on MiniMRCluster
> for writing tests. Many users do as well. MiniMRCluster, however, exposes MR
> implementation details like the existence of TaskTrackers, JobTrackers, etc,
> since it was used by MR1 for testing the server implementations as well.
> This JIRA is to create a new interface which could be implemented either by
> MR1 or MR2 that exposes only the client-side portions of the MR framework.
> Ideally it would be "recompile-compatible" with MiniMRCluster for most
> applications, and the MR1 implementation could be backported to 20x branch.
> Thus, dependent projects like HBase could migrate to this implementation and
> test against both MR1 and MR2. We can also use this to port over the current
> functional tests that use only the client-side features of MiniMRCluster.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira