[ 
https://issues.apache.org/jira/browse/MAPREDUCE-3387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13169768#comment-13169768
 ] 

Vinod Kumar Vavilapalli commented on MAPREDUCE-3387:
----------------------------------------------------

Patch looks good to me overall.

The javadoc problem perhaps is for the edits to java comments you made to 
ProxyUriUtils. getProxyUri() (Just in case you are still searching). Eclipse 
formatting suggest a bunch of tabs before 'a default path "/" can be used.'

Not related to your patch, but we don't need TestProxyUriUtils.TestAppId? 
Instead we can use the BuilderUtils.newApplicationId() method?

Oh, and can you please do a sanity run and verify the expected behavior? I 
don't have access to a cluster, so..
                
> A tracking URL of N/A before the app master is launched breaks oozie
> --------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3387
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3387
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0, 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>            Priority: Critical
>         Attachments: MR-3387.txt, MR-3387.txt
>
>
> When oozie launches a map/reduce job it retrieves the tracking URL of that 
> job to display in its own UI.  Previously this tracking URL did not change 
> except when the job completed.  Currently the URL starts out as N/A and then 
> changes to the real URL once the AppMaster launches.  This breaks oozie, as 
> oozie expects to be able to get that information quickly and get back to 
> processing other requests.
> Because the web app proxy is now available we can maintain backwards 
> compatibility by instead of returning N/A we can return the URL of the proxy 
> for that application.  This relies on the fact that the application master's 
> UI will display the correct thing for the URI http://<host>:<port>/, which MR 
> and others now do.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to