[ 
https://issues.apache.org/jira/browse/MAPREDUCE-3547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176330#comment-13176330
 ] 

Hitesh Shah commented on MAPREDUCE-3547:
----------------------------------------

Mostly looks good. 

Minor comment on the mock classes introduced - given that other unit tests are 
using their own mocks of the these classes and that these mocks are only likely 
to be used by the webapp unit tests, it might be better to move them into the 
webapp package. 
                
> finish unit tests for web services for RM and NM
> ------------------------------------------------
>
>                 Key: MAPREDUCE-3547
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3547
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Thomas Graves
>            Assignee: Thomas Graves
>            Priority: Critical
>         Attachments: MAPREDUCE-3547.patch, MAPREDUCE-3547.patch
>
>
> Write more unit tests for the web services added for rm and nm.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to