[
https://issues.apache.org/jira/browse/MAPREDUCE-3481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192927#comment-13192927
]
Ravi Gummadi commented on MAPREDUCE-3481:
-----------------------------------------
Patch looks good overall.
Some minor comments:
(1) You changed "return" to "break" in the while loop in
StressReaderThread.run() when an InterruptedException is seen. "return" seems
to be better.
(2) The return value from calcEffectiveIncompleteMapTasks() is taken in to a
variable called "mapSlotsBackFill", which is misleading. Please change it to
mapLoad or similar name.
> [Gridmix] Improve STRESS mode locking
> -------------------------------------
>
> Key: MAPREDUCE-3481
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3481
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: contrib/gridmix
> Affects Versions: 0.24.0
> Reporter: Amar Kamat
> Assignee: Amar Kamat
> Labels: gridmix, locking, stress-mode
> Fix For: 0.24.0
>
> Attachments: MAPREDUCE-3481-v1.6.patch
>
>
> Gridmix STREES mode code doesnt sufficiently load the cluster due to improper
> locking.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
