[
https://issues.apache.org/jira/browse/MAPREDUCE-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203767#comment-13203767
]
Jason Lowe commented on MAPREDUCE-3816:
---------------------------------------
Patch looks pretty good. Some comments:
* CSQueueUtils.java seems to have been reformatted, which adds a lot of diffs
to the patch that aren't necessary
* In CSQueueUtils.checkAbsoluteCapacities(), do we need to worry about floating
point precision when comparing absMaxCapacity with absCapacity? Wondering if
we need a tolerance there to handle floating point computation errors.
* Super-Nit: In ParentQueue.java and LeafQueue.java, we should add the
@Override decorator to setUsedCapacity() and setAbsoluteUsedCapacity()
> capacity scheduler web ui bar graphs for used capacity wrong
> ------------------------------------------------------------
>
> Key: MAPREDUCE-3816
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3816
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 0.23.0
> Reporter: Thomas Graves
> Assignee: Thomas Graves
> Priority: Critical
> Attachments: MAPREDUCE-3816.patch, MAPREDUCE-3816.patch,
> MAPREDUCE-3816.patch, capacityschedabsoluteCapacities.png,
> capacityschedulerusedcap.png, capschedulerFixedBarGraph.png
>
>
> The capacity scheduler web ui has bar graphs showing the capacity/used
> capacity/max capacity for each queue. The used capacity it is showing is
> actually the % of its parents queue it is using, which doesn't make sense on
> the bar graphs when compared to the capacity and max capacity of that
> particular queue. The bar graphs should be using utilization so that the
> user can see that its using x% or the y% allocated to that queue.
> I will attach some screen shots showing the issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
