[
https://issues.apache.org/jira/browse/MAPREDUCE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210535#comment-13210535
]
Robert Joseph Evans commented on MAPREDUCE-3877:
------------------------------------------------
I like the concept of the patch. One minor issue with it though In
BreakableService.java inside private int convert(STATE state) the switch has a
default state that returns 0. I would prefer to see the default throw an
exception. default means that for some reason STATE was modified and we want to
detect that instead of silently counting extra NOINITED.
> Add a test to formalise the current state transitions of the yarn lifecycle
> ---------------------------------------------------------------------------
>
> Key: MAPREDUCE-3877
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3877
> Project: Hadoop Map/Reduce
> Issue Type: Test
> Components: mrv2
> Affects Versions: 0.24.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Minor
> Attachments: MAPREDUCE-3877.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Add a test service that counts the number of times it's state methods are
> called; and can be set to raise an exception on any such entry. Use it to
> show what the current lifecycle state model is, so that unintentional
> regressions can be detected.
> It will also act as a foundation for intentional changes to that lifecycle
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
