[ 
https://issues.apache.org/jira/browse/MAPREDUCE-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218318#comment-13218318
 ] 

Thomas Graves commented on MAPREDUCE-3920:
------------------------------------------


Mostly looks good. Since no one has spoken up with objections I don't see any 
harm in changing these as a user can always override.  

A couple minor nits.  I think the following files don't need to change as they 
aren't changing port numbers, just values that happen to be value that match 
one of the ports you changed.  Can you remove those from the patch?

- 
hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/api/protocolrecords/impl/pb/TestPBRecordImpl.java
- 
hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/TestContainer.java
- 
hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/MockLocalResourceStatus.java
 -  
hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/TestResourceLocalizationService.java
- 
hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/MockLocalizerStatus.java
 
-  hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-
nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/TestLocalizedResource.java
 
- 
hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapreduce/filecache/TestTrackerDistributedCacheManager.java
                
> Revise yarn default port number selection
> -----------------------------------------
>
>                 Key: MAPREDUCE-3920
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3920
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: nodemanager, resourcemanager
>    Affects Versions: 0.23.1
>            Reporter: Dave Thompson
>            Assignee: Dave Thompson
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3920-branch-0.23.1.patch, 
> MAPREDUCE-3920-branch-0.23.1.patch
>
>
> The default port numbers chosen for nodemanager and resourcemanager are 
> random and widely spread out creating unnecessary overhead in deployments 
> where site operators care, and deploy many clusters.
> Current and proposed new default ports are as follows:
> Current               New             Config Property 
> -------       ---             ---------------
> 4344          8040            yarn.nodemanager.localizer.address      
> 45454         8041            yarn.nodemanager.address        
> 9999          8042            yarn.nodemanager.webapp.address 
> 8030          8030(NC)        yarn.resourcemanager.scheduler.address
> 8025          8031            yarn.resourcemanager.resource-tracker.address
> 8040          8032            yarn.resourcemanager.address
> 8141          8033            yarn.resourcemanager.admin.address
> Affected files include:  embedded defaults (YarnConfiguration.java), 
> yarn-default.xml, documentation and unit tests.
>  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to