[ 
https://issues.apache.org/jira/browse/MAPREDUCE-3829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220692#comment-13220692
 ] 

Amar Kamat commented on MAPREDUCE-3829:
---------------------------------------

Thanks Ravi for the patch. Few comments:
# It would be nice to move the FileSystem, size and path checks to the 
writeInputData() API. This way you can test this API and the current fix via 
JUnit tests.
# Add JUnit tests to test 
   ## writeInputData() w.r.t zero-data size, missing input dir
   ## 777 permissions on io-path.
                
> [Gridmix] Gridmix should give better error message when input-data directory 
> already exists and -generate option is given
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3829
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3829
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: contrib/gridmix
>            Reporter: Ravi Gummadi
>            Assignee: Ravi Gummadi
>         Attachments: 3829.v0.patch, 3829.v1.patch
>
>
> Instead of throwing exception messages on to the console, Gridmix should give 
> better error message when input-data directory already exists and -generate 
> option is given.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to