[ 
https://issues.apache.org/jira/browse/MAPREDUCE-3876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221857#comment-13221857
 ] 

Steve Loughran commented on MAPREDUCE-3876:
-------------------------------------------

quick look at the patch
* includes diffs from other files; please strip
* system.out code. please replace with (guarded) log at debug
* lots of things commented out. Just delete them, as SVN is for rollbacks
* There seems (at a quick glance) to be a fair bit of duplication between the 
oracle/not oracle branches -that's going to create a lot of maintenance 
downstream, and complicate testing. It'd be nice to have some way of building 
the operations that isn't a complete fork
* Testing. Is there some way to have some tests that can be enabled/disabled 
for different databases. I doubt there are any now, and this could be a good 
time to start
* It's best to have these patches against trunk/0.23+ and then pushed back into 
1.x. There must not be any fixes in that branch that aren't also in trunk.

Finally, I don't know enough about the DB classes to actually assess whether or 
not the code actually works. I'll leave that to others
                
> vertica query, sql command not properly ended
> ---------------------------------------------
>
>                 Key: MAPREDUCE-3876
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3876
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 1.0.0
>         Environment: Red Hat 5.5
> Oracle 11
>            Reporter: Joseph Doss
>              Labels: hadoop, newbie, patch
>         Attachments: HADOOP-oracleDriver-src.patch
>
>
> When running a test script, we're getting a java IO exception thrown.
> This test works on hadoop-0.20.0 but not on hadoop-1.0.0.
> Fri Feb 17 11:36:40 EST 2012
> Running processes with name syncGL.sh: 0
> LIB_JARS: 
> /home/hadoop/verticasync/lib/vertica_4.1.14_jdk_5.jar,/home/hadoop/verticasync/lib/mail.jar,/home/hadoop/verticasync/lib/jdbc14.jar
> VERTICA_SYNC_JAR: /home/hadoop/verticasync/lib/vertica-sync.jar
> PROPERTIES_FILE: 
> /home/hadoop/verticasync/config/ssp-vertica-sync-gl.properties
> Starting Vertica data sync - GL - process
> Warning: $HADOOP_HOME is deprecated.
> 12/02/17 11:36:43 INFO mapred.JobClient: Running job: job_201202171122_0001
> 12/02/17 11:36:44 INFO mapred.JobClient:  map 0% reduce 0%
> 12/02/17 11:36:56 INFO mapred.JobClient: Task Id : 
> attempt_201202171122_0001_m_000000_0, Status : FAILED
> java.io.IOException: ORA-00933: SQL command not properly ended
>       at 
> org.apache.hadoop.mapred.lib.db.DBInputFormat.getRecordReader(DBInputFormat.java:289)
>       at 
> org.apache.hadoop.mapred.MapTask$TrackedRecordReader.<init>(MapTask.java:197)
>       at org.apache.hadoop.mapred.MapTask.runOldMapper(MapTask.java:418)
>       at org.apache.hadoop.mapred.MapTask.run(MapTask.java:372)
>       at org.apache.hadoop.mapred.Child$4.run(Child.java:255)
>       at java.security.AccessController.doPrivileged(Native Method)
>       at javax.security.auth.Subject.doAs(Subject.java:396)
>       at 
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1083)
>       at org.apache.hadoop.mapred.Child.main(Child.java:249)
> 12/02/17 11:36:57 INFO mapred.JobClient: Task Id : 
> attempt_201202171122_0001_m_000001_0, Status : FAILED
> java.io.IOException: ORA-00933: SQL command not properly ended
>       at 
> org.apache.hadoop.mapred.lib.db.DBInputFormat.getRecordReader(DBInputFormat.java:289)
>       at 
> org.apache.hadoop.mapred.MapTask$TrackedRecordReader.<init>(MapTask.java:197)
>       at org.apache.hadoop.mapred.MapTask.runOldMapper(MapTask.java:418)
>       at org.apache.hadoop.mapred.MapTask.run(MapTask.java:372)
>       at org.apache.hadoop.mapred.Child$4.run(Child.java:255)
>       at java.security.AccessController.doPrivileged(Native Method)
>       at javax.security.auth.Subject.doAs(Subject.java:396)
>       at 
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1083)
>       at org.apache.hadoop.mapred.Child.main(Child.java:249)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to