[
https://issues.apache.org/jira/browse/MAPREDUCE-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230501#comment-13230501
]
Hadoop QA commented on MAPREDUCE-1740:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12518506/MAPREDUCE-1740_trunk.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.mapred.TestWritableJobConf
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2059//testReport/
Console output:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2059//console
This message is automatically generated.
> NPE in getMatchingLevelForNodes when node locations are variable depth
> ----------------------------------------------------------------------
>
> Key: MAPREDUCE-1740
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1740
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
> Affects Versions: 0.20.3
> Reporter: Todd Lipcon
> Attachments: MAPREDUCE-1740.patch, MAPREDUCE-1740_branch-1.0.patch,
> MAPREDUCE-1740_trunk.patch, mapreduce-1740.txt
>
>
> In getMatchingLevelForNodes, we assume that both nodes have the same "depth"
> (ie number of path components). If the user provides a topology script that
> assigns one node a path like /foo/bar/baz and another node a path like
> /foo/blah, this function will throw an NPE.
> I'm not sure if there are other places where we assume that all node
> locations have a constant number of paths. If so we should check the output
> of the topology script aggressively to be sure this is the case. Otherwise I
> think we simply need to add && n2 != null to the while loop
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
