[
https://issues.apache.org/jira/browse/MAPREDUCE-4014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230587#comment-13230587
]
Steve Loughran commented on MAPREDUCE-4014:
-------------------------------------------
I've looked at the code and written the tests, the {{CompositeService}} seems
good apart from MAPREDUCE-4016, where I need to verify that sharing of
configurations is not a feature people actually wanted. If MAPREDUCE-4015 was
included -a {{YarnException}} subclass specifically for illegal state changes,
{{CompositeService.init()}} could be extended to relay this exception up,
rather than wrap it.
The patch I'm submitting has merged in the {{AbstractService}} changes to aid
making service stop operations robust regardless of service state; these were
taken from MAPREDUCE-3502. When committed, and MAPREDUCE-4015/MAPREDUCE-4016
resolved, this should complete the yarn-common changes and then specific
services can be reviewed.
> Make yarn-common services robust
> --------------------------------
>
> Key: MAPREDUCE-4014
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4014
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: mrv2
> Affects Versions: 0.23.1, 0.24.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Labels: yarn
> Attachments: MAPREDUCE-4014.patch
>
>
> Review the yarn common services ({{CompositeService}},
> {{AbstractLivelinessMonitor}} and make their service startup _and especially
> shutdown_ more robust against out-of-lifecycle invocation and partially
> complete initialization.
> Write tests for these where possible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
