[
https://issues.apache.org/jira/browse/MAPREDUCE-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243860#comment-13243860
]
Hadoop QA commented on MAPREDUCE-4093:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12520792/MAPREDUCE-4093.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.mapreduce.v2.TestMiniMRProxyUser
org.apache.hadoop.mapreduce.v2.TestSpeculativeExecution
org.apache.hadoop.mapred.TestSpecialCharactersInOutputPath
org.apache.hadoop.mapreduce.v2.TestRMNMInfo
org.apache.hadoop.mapred.TestReduceFetchFromPartialMem
org.apache.hadoop.mapred.TestLazyOutput
org.apache.hadoop.mapreduce.TestChild
org.apache.hadoop.mapred.TestReduceFetch
org.apache.hadoop.mapred.TestMiniMRBringup
org.apache.hadoop.mapred.TestMiniMRClientCluster
org.apache.hadoop.mapreduce.lib.output.TestJobOutputCommitter
org.apache.hadoop.mapreduce.v2.TestMROldApiJobs
org.apache.hadoop.mapreduce.v2.TestNonExistentJob
org.apache.hadoop.mapred.TestMiniMRChildTask
org.apache.hadoop.mapred.TestJobCounters
org.apache.hadoop.mapreduce.v2.TestUberAM
org.apache.hadoop.conf.TestNoDefaultsJobConf
org.apache.hadoop.mapred.TestJobSysDirWithDFS
org.apache.hadoop.mapreduce.v2.TestMRJobs
org.apache.hadoop.mapred.TestClientRedirect
org.apache.hadoop.mapred.TestJobCleanup
org.apache.hadoop.mapreduce.TestMapReduceLazyOutput
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2123//testReport/
Console output:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2123//console
This message is automatically generated.
> Improve RM WebApp start up when proxy address is not set
> --------------------------------------------------------
>
> Key: MAPREDUCE-4093
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4093
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: mrv2
> Affects Versions: 2.0.0, 3.0.0
> Reporter: Devaraj K
> Attachments: MAPREDUCE-4093.patch
>
>
> {code:title=ResourceManager.java|borderStyle=solid}
> protected void startWepApp() {
> Builder<ApplicationMasterService> builder =
> WebApps.$for("cluster", ApplicationMasterService.class, masterService,
> "ws").at(
> this.conf.get(YarnConfiguration.RM_WEBAPP_ADDRESS,
> YarnConfiguration.DEFAULT_RM_WEBAPP_ADDRESS));
> if(YarnConfiguration.getRMWebAppHostAndPort(conf).
> equals(YarnConfiguration.getProxyHostAndPort(conf))) {
> AppReportFetcher fetcher = new AppReportFetcher(conf,
> getClientRMService());
> builder.withServlet(ProxyUriUtils.PROXY_SERVLET_NAME,
> ProxyUriUtils.PROXY_PATH_SPEC, WebAppProxyServlet.class);
> builder.withAttribute(WebAppProxy.FETCHER_ATTRIBUTE, fetcher);
> String proxy = YarnConfiguration.getProxyHostAndPort(conf);
> String[] proxyParts = proxy.split(":");
> builder.withAttribute(WebAppProxy.PROXY_HOST_ATTRIBUTE, proxyParts[0]);
> }
> webApp = builder.start(new RMWebApp(this));
> }
> {code}
> In the above code, YarnConfiguration.getProxyHostAndPort(conf) is invoking
> twice. getProxyHostAndPort() internally invokes getRMWebAppHostAndPort()
> which resolves RM web app address when proxy address is not set.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
