[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245090#comment-13245090
 ] 

Bhallamudi Venkata Siva Kamesh commented on MAPREDUCE-4024:
-----------------------------------------------------------

I don't know whether I can comment here or not (as the jira has already been 
closed), but here is my observation from the patch

{code:title=RMWebServices.java|borderStyle=solid}
if (finalStatusQuery != null && !finalStatusQuery.isEmpty()) {
       FinalApplicationStatus.valueOf(finalStatusQuery);
        if (!rmapp.getFinalApplicationStatus().toString()
            .equalsIgnoreCase(finalStatusQuery)) {
          continue;
        }
      }
{code} 

>From the above code, I think the following statement
{noformat}FinalApplicationStatus.valueOf(finalStatusQuery);{noformat}
validates whether a given string is one of the FinalApplicationStatus's enum 
types.If the enum type is in uppercase and user has given the same enum type in 
lowercase, this statement throws *IllegalArgumentException*. 

However, in the next statement we are comparing strings using 
*equalIgnoreCase*, so from this, I *assume* that, finalStatusQuery can also be 
given in a lowercase. But it won't work.

Please ignore this comment, if my observation is wrong.
                
> RM webservices can't query on finalStatus
> -----------------------------------------
>
>                 Key: MAPREDUCE-4024
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4024
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.2
>            Reporter: Thomas Graves
>            Assignee: Thomas Graves
>             Fix For: 0.23.3
>
>         Attachments: MAPREDUCE-4024.patch
>
>
> The resource manager web service api to get the list of apps doesn't have a 
> query parameter for finalStatus.  It has one for the state but since that 
> isn't what is reported by app master so we really need to be able to query on 
> both state and finalStatus.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to