[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245260#comment-13245260
 ] 

Alejandro Abdelnur commented on MAPREDUCE-4098:
-----------------------------------------------

@Ahmed, as you indicated, the new assertion verifies that the 
YARN_APPLICATION_CLASSPATH value is in the resulting classpath. If we change 
the default value, the test will still pass. This seems more correct than 
checking against a hardcoded value. I don't think we need check for hardcoded 
values, at least not in this test. If you see value in that, we should have an 
additional test checking the hardcoded value; personally I don't think such 
test is needed. Regarding your second comment, the check for contains is 
because the classpath is massaged to prefix '$PWD' and to postfix 'job.jar' and 
'$PWD/*'.
                
> TestMRApps testSetClasspath fails
> ---------------------------------
>
>                 Key: MAPREDUCE-4098
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4098
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 2.0.0
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>             Fix For: 2.0.0
>
>         Attachments: MAPREDUCE-4098.patch
>
>
> The assertion of this test is testing for equality, as the generated 
> classpath file is in the classpath the test fails.
> Instead, the test should test for the expected path elements to be in the 
> classspath.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to