[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans updated MAPREDUCE-4110:
-------------------------------------------

    Status: Open  (was: Patch Available)

The changes look good for the most part.

However, I would prefer to see the tests updated to use the MiniMRYarnCluster 
instead of the MiniMRCluster, as these are our own internal tests.  If you 
would prefer to file a separate JIRA for that I am fine with it.

I am also not really sure that we need TestMiniMRClasspath.testClassPath.  
There are already numerous tests that verify that we can run a word count job 
while setting the classpath. Adding in another, even though it predates some of 
the ones currently used, just seems like it would slow down testing and not 
improve the overall quality of the unit tests.
                
> Fix tests in org.apache.hadoop.mapred.TestMiniMRClasspath & 
> org.apache.hadoop.mapred.TestMiniMRWithDFSWithDistinctUsers
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4110
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4110
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>          Components: mrv2, test
>    Affects Versions: 2.0.0, 3.0.0
>            Reporter: Devaraj K
>            Assignee: Devaraj K
>         Attachments: MAPREDUCE-4110.patch
>
>
> Sub Project : *hadoop-mapreduce-client-jobclient*
> {code:xml}
> Running org.apache.hadoop.mapred.TestMiniMRClasspath
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0.032 sec
> {code}
> {code:xml}
> Running org.apache.hadoop.mapred.TestMiniMRWithDFSWithDistinctUsers
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0.031 sec
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to