[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13248749#comment-13248749
 ] 

Ahmed Radwan commented on MAPREDUCE-4105:
-----------------------------------------

Thanks Tom for reviewing this!

The test checks that setConf() is called by inspecting the script filename is 
correct (which is passed through the conf). So, this way we check that the conf 
is passed and also that the script name is correct in the same time.

The reason for adding a new test class is that RackResolver.init() is a static 
method, and it checks if it was called before and returns. So when I added a 
new test method to the existing TestRackResolver what happened is that the 
NET_TOPOLOGY_NODE_SWITCH_MAPPING_IMPL_KEY class get set by the test method that 
initializes the RackResolver first. What we want is a different initialization 
using ScriptBasedMapping.class.

DNSToSwitchMapping is not Configurable.
                
> Yarn RackResolver ignores rack configurations
> ---------------------------------------------
>
>                 Key: MAPREDUCE-4105
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4105
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.1
>            Reporter: Ahmed Radwan
>            Assignee: Ahmed Radwan
>             Fix For: 0.23.2
>
>         Attachments: MAPREDUCE-4105.patch
>
>
> Incorrect mappings because the Yarn RackResolver ignores rack configurations. 
> This can be verified by inspecting the resource manager web ui that lists all 
> the nodes, all of them show up with /default-rack regardless of the output 
> from the script specified using net.topology.script.file.name configuration 
> property.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to