[ 
https://issues.apache.org/jira/browse/MAPREDUCE-3958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251172#comment-13251172
 ] 

Hadoop QA commented on MAPREDUCE-3958:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12522175/MAPREDUCE-3958.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 6 new or modified test 
files.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    -1 core tests.  The patch failed these unit tests:
                  
org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes
                  
org.apache.hadoop.yarn.server.resourcemanager.TestClientRMService
                  
org.apache.hadoop.yarn.server.resourcemanager.resourcetracker.TestNMExpiry
                  
org.apache.hadoop.yarn.server.resourcemanager.TestAMAuthorization
                  
org.apache.hadoop.yarn.server.resourcemanager.TestApplicationACLs

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2193//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2193//console

This message is automatically generated.
                
> RM: Remove RMNodeState and replace it with NodeState
> ----------------------------------------------------
>
>                 Key: MAPREDUCE-3958
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3958
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Bikas Saha
>            Assignee: Bikas Saha
>             Fix For: 0.23.2
>
>         Attachments: MAPREDUCE-3958.patch
>
>
> RMNodeState is being sent over the wire after MAPREDUCE-3353. This has been 
> done by cloning the enum into NodeState in yarn protocol records.
> That makes RMNodeState redundant and it should be replaced with NodeState.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to